This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Add share option to properties and storagelist #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Aug 21, 2018
app/util/shareMenuTemplate.js
Outdated
| @@ -0,0 +1,31 @@ | |||
| import { remote } from 'electron' | |||
There was a problem hiding this comment.
Should we move this to app/lib/sharing (example) ?
| }) | ||
| return Promise.resolve(hashes) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Should we move these functions into app/lib/sharing/?
|
What should go into the |
|
Yes! (tests are failing) 😮 |
koalalorenzo
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Insert here the changes.